-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: don't list commits abandoned by import/fetch, just print the number #2321
Conversation
Looking at the tests, one downside of this is that without any commit ids, the user might wonder if something important was abandoned. They might think this anyway, but with a commit id they'll see that it's an old version of a commit that they still have (in the common case) or from a branch they just deleted. This might be helped by printing a couple of commit summaries and then saying "Abandoned XX more commits". Or we could try it as is, or perhaps another idea will appear. |
Perhaps "Abandoned 5 no longer relevant commits" would calm people down compared to "Abandoned 5 commits."? We could try something like that and see if that's good enough. Somewhat surprisingly, I think it'd calm me down somewhat if I was new to |
How about "Abandoned N obsolete commits"? |
I think a new person might not understand the difference between "abandoned" and "obsolete". Something like "that became obsolete after the refs moved" or "that became obsolete after the remote-tracking branch was deleted" would be OK. |
Maybe "Abandoned NN commits that became obsolete due to the changes to branches or other refs."? You can later change the message to mention the specific refs in question. |
Or "Abandoned N commits that are no longer reachable."? Is that accurate and clear enough? |
I think that's good enough for me. I'd prefer it if we mentioned branches or something as the cause, but my version is admittedly a bit verbose and I can't immediately come up with a better one. |
Apparently, it gets too verbose if the remote history is actively rewritten. Let's summarize the output for now. The plan is to show the list of moved refs instead of the full list of abandoned commits.
3e243fb
to
2f4ef50
Compare
Thank you! |
Apparently, it gets too verbose if the remote history is actively rewritten. Let's summarize the output for now. The plan is to show the list of moved refs instead of the full list of abandoned commits.
Checklist
If applicable:
CHANGELOG.md